Skip to content

Commit

Permalink
enhance: Decrease bloom filter fp rate to reduce delete impact (milvu…
Browse files Browse the repository at this point in the history
…s-io#33301)

when milvus process delete record, it need to find record's corresponded
segment by bloom filter, and higher bloom filter fp rate will cause
delete record forwards to wrong segments.

This PR Decrease bloom filter's default fp to 0.001.

Signed-off-by: Wei Liu <[email protected]>
  • Loading branch information
weiliu1031 authored May 23, 2024
1 parent 6c18611 commit c7be2ce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion configs/milvus.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ common:
ttMsgEnabled: true # Whether the instance disable sending ts messages
traceLogMode: 0 # trace request info
bloomFilterSize: 100000 # bloom filter initial size
maxBloomFalsePositive: 0.05 # max false positive rate for bloom filter
maxBloomFalsePositive: 0.001 # max false positive rate for bloom filter

# QuotaConfig, configurations of Milvus quota and limits.
# By default, we enable:
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/paramtable/component_param.go
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ like the old password verification when updating the credential`,
p.MaxBloomFalsePositive = ParamItem{
Key: "common.maxBloomFalsePositive",
Version: "2.3.2",
DefaultValue: "0.05",
DefaultValue: "0.001",
Doc: "max false positive rate for bloom filter",
Export: true,
}
Expand Down

0 comments on commit c7be2ce

Please sign in to comment.