forked from milvus-io/milvus
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
enhance: Add in-memory cache for casbin enforcer result (milvus-io#35271
) See also milvus-io#35270 --------- Signed-off-by: Congqi Xia <[email protected]>
- Loading branch information
Showing
6 changed files
with
190 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| // Licensed to the LF AI & Data foundation under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package proxy | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "sync" | ||
|
|
||
| "go.uber.org/atomic" | ||
|
|
||
| "github.com/milvus-io/milvus/pkg/util/typeutil" | ||
| ) | ||
|
|
||
| var ( | ||
| priCacheInitOnce sync.Once | ||
| priCacheMut sync.RWMutex | ||
| priCache *PrivilegeCache | ||
| ver atomic.Int64 | ||
| ) | ||
|
|
||
| func getPriCache() *PrivilegeCache { | ||
| priCacheMut.RLock() | ||
| c := priCache | ||
| priCacheMut.RUnlock() | ||
|
|
||
| if c == nil { | ||
| priCacheInitOnce.Do(func() { | ||
| priCacheMut.Lock() | ||
| defer priCacheMut.Unlock() | ||
| c = &PrivilegeCache{ | ||
| version: ver.Inc(), | ||
| values: typeutil.ConcurrentMap[string, bool]{}, | ||
| } | ||
| priCache = c | ||
| }) | ||
| } | ||
|
|
||
| return c | ||
| } | ||
|
|
||
| func CleanPrivilegeCache() { | ||
| priCacheMut.Lock() | ||
| defer priCacheMut.Unlock() | ||
| priCache = &PrivilegeCache{ | ||
| version: ver.Inc(), | ||
| values: typeutil.ConcurrentMap[string, bool]{}, | ||
| } | ||
| } | ||
|
|
||
| func GetPrivilegeCache(roleName, object, objectPrivilege string) (isPermit, cached bool, version int64) { | ||
| key := fmt.Sprintf("%s_%s_%s", roleName, object, objectPrivilege) | ||
| c := getPriCache() | ||
| isPermit, cached = c.values.Get(key) | ||
| return isPermit, cached, c.version | ||
| } | ||
|
|
||
| func SetPrivilegeCache(roleName, object, objectPrivilege string, isPermit bool, version int64) { | ||
| key := fmt.Sprintf("%s_%s_%s", roleName, object, objectPrivilege) | ||
| c := getPriCache() | ||
| if c.version == version { | ||
| c.values.Insert(key, isPermit) | ||
| } | ||
| } | ||
|
|
||
| // PrivilegeCache is a cache for privilege enforce result | ||
| // version provides version control when any policy updates | ||
| type PrivilegeCache struct { | ||
| values typeutil.ConcurrentMap[string, bool] | ||
| version int64 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // Licensed to the LF AI & Data foundation under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package proxy | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/suite" | ||
| ) | ||
|
|
||
| type PrivilegeCacheSuite struct { | ||
| suite.Suite | ||
| } | ||
|
|
||
| func (s *PrivilegeCacheSuite) TearDownTest() { | ||
| CleanPrivilegeCache() | ||
| } | ||
|
|
||
| func (s *PrivilegeCacheSuite) TestGetPrivilege() { | ||
| // get current version | ||
| _, _, version := GetPrivilegeCache("", "", "") | ||
| SetPrivilegeCache("test-role", "test-object", "read", true, version) | ||
| SetPrivilegeCache("test-role", "test-object", "delete", false, version) | ||
|
|
||
| type testCase struct { | ||
| tag string | ||
| input [3]string | ||
| expectIsPermit bool | ||
| expectExists bool | ||
| } | ||
|
|
||
| testCases := []testCase{ | ||
| {tag: "exist_true", input: [3]string{"test-role", "test-object", "read"}, expectIsPermit: true, expectExists: true}, | ||
| {tag: "exist_false", input: [3]string{"test-role", "test-object", "delete"}, expectIsPermit: false, expectExists: true}, | ||
| {tag: "not_exist", input: [3]string{"guest", "test-object", "delete"}, expectIsPermit: false, expectExists: false}, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| s.Run(tc.tag, func() { | ||
| isPermit, exists, _ := GetPrivilegeCache(tc.input[0], tc.input[1], tc.input[2]) | ||
| s.Equal(tc.expectIsPermit, isPermit) | ||
| s.Equal(tc.expectExists, exists) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func (s *PrivilegeCacheSuite) TestSetPrivilegeVersion() { | ||
| // get current version | ||
| _, _, version := GetPrivilegeCache("", "", "") | ||
| CleanPrivilegeCache() | ||
|
|
||
| SetPrivilegeCache("test-role", "test-object", "read", true, version) | ||
|
|
||
| isPermit, exists, nextVersion := GetPrivilegeCache("test-role", "test-object", "read") | ||
| s.False(isPermit) | ||
| s.False(exists) | ||
| s.NotEqual(version, nextVersion) | ||
| } | ||
|
|
||
| func TestPrivilegeSuite(t *testing.T) { | ||
| suite.Run(t, new(PrivilegeCacheSuite)) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters