enhance: Remove unnecessary clone in SetState (milvus-io#37697)

issue: milvus-io#37637 --------- Signed-off-by: bigsheeper <[email protected]>
bigsheeper · Nov 15, 2024 · 18a6478 · 18a6478
1 parent 81fa7dd
commit 18a6478
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/internal/datacoord/meta.go b/internal/datacoord/meta.go
@@ -642,7 +642,7 @@ func (m *meta) SetState(segmentID UniqueID, targetState commonpb.SegmentState) e
 		// Apply segment metric update after successful meta update.
 		metricMutation.commit()
 		// Update in-memory meta.
-		m.segments.SetState(segmentID, targetState)
+		m.segments.SetSegment(segmentID, clonedSegment)
 	}
 	log.Info("meta update: setting segment state - complete",
 		zap.Int64("segmentID", segmentID),

diff --git a/internal/datacoord/segment_info.go b/internal/datacoord/segment_info.go
@@ -219,14 +219,6 @@ func (s *SegmentsInfo) SetRowCount(segmentID UniqueID, rowCount int64) {
 	}
 }
 
-// SetState sets Segment State info for SegmentInfo with provided segmentID
-// if SegmentInfo not found, do nothing
-func (s *SegmentsInfo) SetState(segmentID UniqueID, state commonpb.SegmentState) {
-	if segment, ok := s.segments[segmentID]; ok {
-		s.segments[segmentID] = segment.Clone(SetState(state))
-	}
-}
-
 // SetDmlPosition sets DmlPosition info (checkpoint for recovery) for SegmentInfo with provided segmentID
 // if SegmentInfo not found, do nothing
 func (s *SegmentsInfo) SetDmlPosition(segmentID UniqueID, pos *msgpb.MsgPosition) {

diff --git a/internal/datacoord/task_stats_test.go b/internal/datacoord/task_stats_test.go
@@ -546,10 +546,12 @@ func (s *statsTaskSuite) TestTaskStats_PreCheck() {
 
 		s.Run("normal case", func() {
 			catalog := catalogmocks.NewDataCoordCatalog(s.T())
+			catalog.EXPECT().AlterSegments(mock.Anything, mock.Anything, mock.Anything).Return(nil)
 			s.mt.catalog = catalog
 			s.mt.statsTaskMeta.catalog = catalog
-			s.mt.segments.SetState(s.segID, commonpb.SegmentState_Flushed)
-			catalog.EXPECT().AlterSegments(mock.Anything, mock.Anything, mock.Anything).Return(nil)
+			updateStateOp := UpdateStatusOperator(s.segID, commonpb.SegmentState_Flushed)
+			err := s.mt.UpdateSegmentsInfo(updateStateOp)
+			s.NoError(err)
 			catalog.EXPECT().SaveStatsTask(mock.Anything, mock.Anything).Return(nil)
 
 			s.NoError(st.SetJobInfo(s.mt))