Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCCP-295] Migrate to alloy #168

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

alstjd0921
Copy link
Member

@alstjd0921 alstjd0921 commented Dec 3, 2024

Description

  • Migrate ethers-rs to alloy-rs
  • Remove tx-manager(legacy & eip1559)
  • Rerun worker if the error seems minor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Something else (simple changes that are not related to existing functionality or others)

Checklist

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have made new test codes regarding to my changes.
  • I have no personal secrets or credentials described on my changes.
  • I have run cargo-clippy and linted my code.
  • My changes generate no new warnings.
  • My changes passed the existing test codes.
  • My changes are able to compile.

@alstjd0921 alstjd0921 added do not merge This pull request should not be merged yet enhancement New feature or request dependencies Pull requests that update a dependency file labels Dec 3, 2024
@alstjd0921 alstjd0921 requested a review from SunoukMun December 3, 2024 09:02
@alstjd0921 alstjd0921 self-assigned this Dec 3, 2024
…on handling

- Removed `byteorder` dependency from `Cargo.toml` files in both root and client directories.
- Updated transaction handling in various handlers to utilize `send_transaction` function for better task management and error handling.
- Introduced `SpawnTaskHandle` in several handlers to facilitate asynchronous task spawning.
- Cleaned up unused code and commented-out sections across multiple files, enhancing overall code readability and maintainability.
- Adjusted imports and struct definitions to reflect the removal of redundant components.

This commit streamlines the codebase by eliminating unnecessary dependencies and improving the transaction processing flow.
- Removed unused traits and functions related to transaction management, enhancing code clarity.
- Simplified imports by eliminating unnecessary components, focusing on essential dependencies.
@alstjd0921 alstjd0921 marked this pull request as ready for review December 10, 2024 09:59
alstjd0921 and others added 3 commits December 11, 2024 15:36
- Added a new method `flush_stalled_transactions` to handle stalled transactions in the transaction pool.
- Enhanced transaction management by adjusting gas prices for legacy and EIP-1559 transactions based on current market conditions.
- Updated the `send_transaction` function to call `flush_stalled_transactions` when encountering a "nonce too low" error, improving error handling and transaction reliability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file do not merge This pull request should not be merged yet enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants