Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 13 clean fix #249

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Angular 13 clean fix #249

wants to merge 21 commits into from

Conversation

venraij
Copy link

@venraij venraij commented Nov 15, 2021

Fixes incompatibility with ng13.

This is a breaking update for all lower versions of angular because of the removal of the MethodCall class from @angular/compiler.

This pr also adds GitHub workflow testing.

Based on @bartholomej and @tiberiuzuld branches

@tarlepp tarlepp mentioned this pull request Nov 15, 2021
@pongells
Copy link

Works for me. Is this repo still maintained? ping @biesbjerg

@AmirSavand
Copy link

AmirSavand commented Nov 16, 2021

The removal of "CommonJS" is really needed 👍🏻

@venraij
Copy link
Author

venraij commented Nov 17, 2021

For those that do want to implement it in some way easily, already use: https://www.npmjs.com/package/@misternick/ngx-translate-extract

Not a promise for LTS though, so keep your eyes peeled on this repo for now.

@salimchemes
Copy link

just tested and it works

@bartholomej
Copy link

bartholomej commented Nov 23, 2021

Great job, guys!
Actually, I still have two issues in this build.

Some more info and updates in my pullrequest
Jeez! so many pull requests! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants