Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tsv): Warn on undefined columns #2104

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

effigies
Copy link
Collaborator

Partially addresses bids-standard/bids-validator#34. Needs a definition for behavioral data in the schema to fully address it.

@effigies effigies force-pushed the feat/warn-undefined-columns branch from 1da9744 to 0a5c7ab Compare August 21, 2024 19:28
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (afbdac6) to head (2c89920).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    bids-standard/legacy-validator#2104      +/-   ##
==========================================
+ Coverage   85.69%   87.68%   +1.98%     
==========================================
  Files          91      133      +42     
  Lines        3782     6975    +3193     
  Branches     1220     1657     +437     
==========================================
+ Hits         3241     6116    +2875     
- Misses        455      764     +309     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwblair rwblair merged commit d232223 into bids-standard:master Aug 23, 2024
16 checks passed
@effigies effigies deleted the feat/warn-undefined-columns branch August 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants