Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add configuration file #2100

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Aug 20, 2024

Introduces a configuration file. The configuration file maps severities (ignore, warning, error) onto lists of partial issues. The partial issues are used to filter the issue list, and the severity of all matching issues are updated.

This is done in order of ignore, warning, error, so any issue that matches multiple will end with the highest severity.

Closes https://github.com/bids-standard/bids-validator/issues/1937.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (06df2f8) to head (e6d3d93).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
+ Coverage   85.69%   87.85%   +2.15%     
==========================================
  Files          91      133      +42     
  Lines        3782     6957    +3175     
  Branches     1220     1655     +435     
==========================================
+ Hits         3241     6112    +2871     
- Misses        455      750     +295     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwblair rwblair merged commit 495de9f into bids-standard:master Aug 21, 2024
16 checks passed
@effigies effigies deleted the cli/config branch August 21, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno: lost --config option?
2 participants