Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Provide baseline definition for behavioral files #1907

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

effigies
Copy link
Collaborator

Part two of resolving https://github.com/bids-standard/bids-validator/issues/1376. Also provides a starting point for behavioral files, instead of being purely free-form. If someone's going to use columns that are defined for events.tsv, they should mean the same thing in beh.tsv.

@effigies effigies requested a review from Remi-Gau August 27, 2024 14:18
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good with me

@effigies effigies added this to the 1.10.0 milestone Aug 29, 2024
@effigies effigies force-pushed the enh/behavioral_table branch from c3f0b3c to 63ef5c8 Compare August 30, 2024 23:10
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (183499c) to head (63ef5c8).
Report is 105 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1907   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          16       16           
  Lines        1410     1410           
=======================================
  Hits         1230     1230           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 15d1906 into bids-standard:master Sep 5, 2024
27 checks passed
@effigies effigies deleted the enh/behavioral_table branch September 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants