Make wording more explicit for _mod and remove MRI specificity of _acq #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (used in other modalities) Relates to a discussion of _mod destiny in bids-standard/bids-2-devel#70
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1778 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
|
I was wide off -- we did clarify modality definition in https://bids-specification.readthedocs.io/en/stable/common-principles.html#definitions and for better or for worse it was Ok and no need to bring in "contrast" here... I will adjust now edit: nah -- better just close ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_acqis also used in other modalities so description should be generic._mod-change relates to a discussion of _mod destiny inbids-standard/bids-2-devel#70
and to accent that it is not really "modality" term (e.g.
mri,eeg, ...) we use generally through out BIDS specification.Some might argue about use of "contrast" to describe
T1wetc but we do use "contrast" to that extent in other places already AFAIK.