Make extensions identifiers contain . to separate extensions where multiple used #1755
Conversation
|
Dots are separators in the schema. This seems like a bad idea. |
|
We could use an underscore instead. |
|
good idea, done, taking out of draft. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1755 +/- ##
=======================================
Coverage 87.92% 87.92%
=======================================
Files 16 16
Lines 1375 1375
=======================================
Hits 1209 1209
Misses 166 166 ☔ View full report in Codecov by Sentry. |
Remi-Gau
added
exclude-from-changelog
effigies
force-pushed
the
enh-ext-period
branch
from
ed50838 to
8772f98
Compare
|
After #1749, we need to update the anchors in these links: ❯ grep -rI 'tsvgz\|niigz' src/**/*.md
src/common-principles.md:[compressed tab-delineated (TSV.GZ) files](glossary.md#tsvgz-extensions) when
src/modality-specific-files/physiological-recordings.md:([TSV.GZ file](../glossary.md#tsvgz-extensions)) and a corresponding
src/modality-specific-files/task-events.md:([TSV.GZ file](../glossary.md#tsvgz-extensions)) and a corresponding |
|
sorry , I am missing why this PR is "relevant" or why they were not spotted/adjusted in #1749 - don't linkchecker tests those as well? |
|
I don't think anchors fail to resolve. And #1749 introduced links to these glossary terms that were not there before. This PR changes the target of those links, so needs to also change the links. |
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i'' -e 's/tsvgz/tsv_gz/g' src/*.md src/*/*.md",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
effigies
force-pushed
the
enh-ext-period
branch
from
7117036 to
95f4833
Compare
|
|
Impact on rendered doc is essentially nil. Invoking admin privileges. |
origin: