Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goldmark-jupyter: support cell attachments in markdown cells #5

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

bevzzz
Copy link
Owner

@bevzzz bevzzz commented Jan 26, 2024

This PR adds a package with extensions for goldmark and nb that, together, add support cell attachments in markdown cells.

Some important remarks:

  • While nb aspires to work with different markdown renderers, not all of them have an extension API that's permissive enough to allow for a similar implementation. This package may serve as a POC / template for extensions that target other renderers.
  • Not publishing goldmark-jupyter as a standalone module (in a separate repo), because it is rather niche and wouldn't be of much use outside of nb "ecosystem".

@bevzzz bevzzz marked this pull request as ready for review January 26, 2024 11:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b138fc5) 82.13% compared to head (d694010) 82.13%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files          11       11           
  Lines         571      571           
=======================================
  Hits          469      469           
  Misses         81       81           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bevzzz bevzzz marked this pull request as draft January 26, 2024 12:18
@bevzzz bevzzz force-pushed the feat/goldmark-jupyter branch from 394e1a0 to d694010 Compare January 26, 2024 21:18
@bevzzz bevzzz force-pushed the feat/goldmark-jupyter branch from d694010 to 1c41b1e Compare January 26, 2024 21:45
@bevzzz bevzzz marked this pull request as ready for review January 26, 2024 21:46
@bevzzz bevzzz merged commit 574bb1e into main Jan 26, 2024
1 check passed
@bevzzz bevzzz deleted the feat/goldmark-jupyter branch January 26, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants