Extension API #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow flexible but precise mime-type matching in the Preference API.
- Register CellRenderFuncs with render.Pref, which allows specifying
both the cell type and the mime-type that the function should handle.
- Replace schema.CellTypeMixed with distinct Type() and MimeType()
fields. The legacy solution blended the two properties, which made
the public API for registerring RenderCellFuncs rigid and confusing.
- Move reusable test doubles to internal/test. After some more polishing
I'm planning to expose them as a separate package to be used by extension
packages in their tests.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 80.00% 81.27% +1.27%
==========================================
Files 5 7 +2
Lines 360 534 +174
==========================================
+ Hits 288 434 +146
- Misses 58 81 +23
- Partials 14 19 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new Extension API.
It offers a clear
nb.Extensioninterface that other packages can implement to render richer content.I've also made the
Renderermore flexible with the new Preference API. With it, custom renderers can now select cells by theirschema.CellTypeor even narrow it down to a specific mime-type. See example usages inhtml.go.This is a breaking change, as it modifies the signature for
Register()method and discontinuesschema.CellTypeMixed.