-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functionally to load preferences/override from a toml file #77
Open
n1ght-hunter
wants to merge
39
commits into
bevyengine:main
Choose a base branch
from
n1ght-hunter:dev/add-plugin-functionalty-to-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add functionally to load preferences/override from a toml file #77
n1ght-hunter
wants to merge
39
commits into
bevyengine:main
from
n1ght-hunter:dev/add-plugin-functionalty-to-settings
+1,909
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ght-hunter
changed the title
Dev/add plugin functionalty to settings
add functionally to save and load preferences/settings
Oct 10, 2024
alice-i-cecile
added
C-Feature
Make something new possible
S-Waiting-on-Author
The author needs to make changes or address concerns before this can be merged
A-Preferences
Setting and saving user and project preferences
labels
Oct 16, 2024
n1ght-hunter
changed the title
add functionally to save and load preferences/settings
add functionally to load preferences/override from a toml file
Oct 26, 2024
This is super exiting, I really hope we can use this soon 🤞(doesn't have to be perfect) |
MiniaczQ
reviewed
Nov 23, 2024
update on this pr i am currently working on rewriting the code to match closer to the bevy reflect serde directory structure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Preferences
Setting and saving user and project preferences
C-Feature
Make something new possible
S-Waiting-on-Author
The author needs to make changes or address concerns before this can be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example data structure
Equivalent toml
what is currently de serializable
Settings types
List merging strategy
Tags