Removed ESIK_Result parameter from the delegate on SIK_JoinLobby_AsyncFunction #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the Steam Result enum from the delegate, as the callback does not actually have a Steam Result enum
Removed the Steam Result enum from the broadcasting of the delegate; we were casting from EChatRoomEnterResponse to EResult, which would give unintended consequences. Also removed the use of ESIK_ChatRoomEnterResponse::None, as the Steam API would return ChatRoomEnterResponseError in the event an error occurred. This "None" could cause issues if a user tried to cast back to an EChatRoomEnterResponse.
|
Side note: I also removed the broadcasting of the ESIK_ChatRoomEnterResponse::None value and replaced it with ESIK_ChatRoomEnterResponse::ChatRoomEnterResponseError as this is the proper response the Steam API would return. I understand if these changes aren't merged, as you may want to go a different direction with it. This was just something I caught while trying to utilize these functions and changed on my personal project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed casting from an EChatRoomEnterResponse to an ESIK_Result and broadcasting that value, which would have unintended consequences if someone tried to use that value. In fact, the LobbyEnter_t callback doesn't even have an EResult property, so I removed it from the delegate altogether.
A good replacement would be to broadcast the Param.m_ulSteamIDLobby of the lobby, which would provide an easy way to see if the callback had a bad response (SteamId would be 0 in this case).