Fix : icône lien externe en double edition masse motif #4928
+8
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineGirard
force-pushed
the
agd/fix-double-external-link-icon
branch
from
cf68e5a to
fc4730e
Compare
adipasquale
approved these changes
Dec 26, 2024
|
|
||
| .rdv-text-align-center.mb-4 |
There was a problem hiding this comment.
pour ma gouverne, qu’est-ce qui ne marchait pas avec la marge à ce niveau?
There was a problem hiding this comment.
Je n’ai pas creusé dans le détail, mais quand on le met ici le bouton passe sous le footer
D’ailleurs un jour, il faudra certainement revoir le footer de ces pages parce qu’il manque un morceau (certainement parce qu’on utilise le même que sur les pages avec le bandeau à gauche)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexte
Suite à l’ajout simultané du DSFR et de l’édition de masse de motif dans l’interface agent, nous avons un double icône de lien externe qui est apparu.
Solution
Suppression de l’icône font awesome en trop.
J’en ai profité pour changer les boutons Bootstrap en boutons DSFR et pour corriger un petit soucis de marge en bas de page.
Captures d'écran