-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration invitation usager et reset password agent au DSFR #4926
Open
AntoineGirard
wants to merge
5
commits into
production
Choose a base branch
from
agd/dsfr-migration-invitation-form-and-reset-password-agent
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d2848f4
Migration invitation usager et reset password agent au DSFR
AntoineGirard 449dbf7
Fix spec
AntoineGirard 1d411aa
Review
AntoineGirard 5565731
Merge branch 'production' into agd/dsfr-migration-invitation-form-and…
adipasquale 0033d05
fix spec
adipasquale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,10 @@ | ||
= form_for resource, as: resource_name, url: password_path(resource_name) do |f| | ||
= form_for resource, as: resource_name, url: password_path(resource_name), builder: DsfrFormBuilder do |f| | ||
.text-center.w-75.m-auto | ||
h4.text-dark-50.text-center.mt-0.font-weight-bold Mot de passe oublié ? | ||
p.text-muted.mb-4 Entrez votre email pour recevoir un lien de réinitialisation de mot de passe | ||
= render "devise/shared/error_messages", resource: resource | ||
.form-group | ||
= f.email_field :email, autofocus: true, required: true, placeholder: "[email protected]", class: "form-control" | ||
.form-group.mb-0.text-center | ||
= f.submit "Envoyer", class: "btn btn btn-primary" | ||
= f.dsfr_email_field :email, label: "Adresse email", hint: "Format attendu : [email protected]", required: true, autofocus: true | ||
.text-center | ||
= f.submit "Envoyer", class: "fr-btn" | ||
|
||
- content_for :footer do | ||
= render "devise/shared/links" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,26 +4,17 @@ | |
= render "users/rdv_wizard_steps/rdv_wizard_summary", rdv_wizard: @rdv_wizard if @rdv_wizard.present? | ||
|
||
.card-body | ||
= simple_form_for resource, as: resource_name, url: invitation_path(resource_name), html: { method: :put } do |f| | ||
= form_for resource, as: resource_name, url: invitation_path(resource_name), html: { method: :put }, builder: DsfrFormBuilder do |f| | ||
.rdv-text-align-center.w-75.m-auto | ||
= render "devise/shared/error_messages", resource: resource | ||
= render "devise/shared/dsfr_error_messages", resource: resource | ||
= f.hidden_field :invitation_token | ||
.form-row | ||
.col-md-6= f.input :first_name, placeholder: "Prénom" | ||
.col-md-6= f.input :last_name, placeholder: "Nom" | ||
.form-row | ||
.fr-grid-row.fr-grid-row--gutters | ||
.fr-col-md-6= f.dsfr_text_field :first_name, label: "Prénom" | ||
.fr-col-md-6= f.dsfr_text_field :last_name, label: "Nom" | ||
- if resource.email.present? | ||
.col-md-12= f.input :email, value: resource.email, disabled: true | ||
.fr-col-md-12= f.dsfr_email_field :email, value: resource.email, disabled: true | ||
- else | ||
.col-md-12= f.input :email, required: true | ||
.form-row | ||
.col-md-12= f.input :phone_number, as: :tel | ||
.form-group | ||
= f.label :password | ||
= f.password_field :password, required: true, class: "form-control", id: "password", autocomplete: "new-password" | ||
span.fa.fa-fw.fa-eye.toggle-password role="button" tabindex="0" | ||
.form-text.small.rdv-color-text-mention-grey.mb-2 | ||
| Choisissez votre mot de passe | ||
|
||
= render "agents/mot_de_passes/new_password_hints" | ||
.rdv-text-align-center= f.button :submit, t("devise.invitations.edit.submit_button") | ||
.fr-col-md-12= f.dsfr_email_field :email, required: true | ||
.fr-col-md-12= f.dsfr_phone_field :phone_number, hint: "Saisissez un numéro à 10 chiffres de France métropole ou d’outre-mer, ou bien un numéro international avec le préfixe du pays." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. je dis vive l’inlining 👍 est-ce que tu penses que la clé i18n |
||
.fr-col-md-12 = render "common/form/new_password_input", f: f | ||
.rdv-text-align-center= f.submit "Enregistrer", class: "fr-btn" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plus qu’une utilisation de ce partial dans
agents/mot_de_passes/edit.html.slim
, on pourrait éventuellement l’y inliner mais ce n’est absolument pas bloquant, je le note juste au passage