Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated bar chart examples #42

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

gisellerosetta
Copy link
Collaborator

Updated the bar chart examples to show more distinct bar heights.
Added an example to the README.

I have not been able to build the cookbook locally to review the content.

Links to #9 and #25

@gisellerosetta gisellerosetta self-assigned this Nov 26, 2024
@gisellerosetta gisellerosetta marked this pull request as draft November 27, 2024 09:14
@gisellerosetta gisellerosetta removed the request for review from Olivia-Box-Power November 27, 2024 09:14
@gisellerosetta gisellerosetta marked this pull request as ready for review November 27, 2024 17:05
Copy link
Collaborator

@Olivia-Box-Power Olivia-Box-Power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bar charts in the following cookbook sections need updating:

  • interactive chats
  • annotations (final barchart)
  • Other customisations (5 charts)
  • Wrapping text (2 charts)
  • Adjusting theme elements

ggplot(pop_bar_data, aes(x = pop/(10^6), y = reorder(country, -pop)))
Could we pass something to the scales function so the axis is labelled in millions?

@gisellerosetta
Copy link
Collaborator Author

Thanks for the feedback Olivia - I've given this a go with scales on the first graph in _chart-types.Rmd as a first try but haven't been able to work out how to scale the data properly.

@Olivia-Box-Power Olivia-Box-Power changed the base branch from main to development January 6, 2025 17:40
@Olivia-Box-Power Olivia-Box-Power merged commit 30dc15e into development Jan 7, 2025
5 of 6 checks passed
@Olivia-Box-Power Olivia-Box-Power deleted the update-bar-chart-examples branch January 7, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update data used to produce charts in cookbook Suggestion: Expand on examples in README
2 participants