Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Return DRAM hash logic to module #503

Open
dpetrisko opened this issue Mar 30, 2021 · 2 comments
Open

Request: Return DRAM hash logic to module #503

dpetrisko opened this issue Mar 30, 2021 · 2 comments
Assignees
Labels

Comments

@dpetrisko
Copy link
Contributor

The DRAM striping logic used to be contained in this hash_function module:

Now it's directly embedded in the EVA to NPA mapping:

wire [vcache_row_id_width_lp-1:0] vcache_row_id = eva_i[2+vcache_word_offset_width_lp+x_subcord_width_lp+:vcache_row_id_width_lp];

The BlackParrot to MC bridge uses this hash function to map its own DRAM to the correct V$ banks. https://github.com/bespoke-silicon-group/hb_bigblade/blob/master/bigblade_bp_unicore/v/bp_cce_to_mc_bridge.sv#L220 However, it doesn't use the rest of the EVA-NAP map.

Can we put this logic back in a dram_hash_function module? BlackParrot will not be the only accelerator which faces this issue

@taylor-bsg
Copy link
Contributor

@tommydcjung do you want to do the refactor or have dan do a pull request?

@tommydcjung
Copy link
Contributor

I can do the refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants