Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 1 #8

Merged
merged 13 commits into from
Aug 24, 2023
Merged

Fixing 1 #8

merged 13 commits into from
Aug 24, 2023

Conversation

bernes1
Copy link
Owner

@bernes1 bernes1 commented Aug 9, 2023

No description provided.

Copy link

@petterroea petterroea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is always some polish to do!

.env_sample Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/index.js Outdated

const client = mqtt.connect(process.env.MQTT_BROKER, options);

let previousState = "";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty is not self-descriptive! I have no idea what state "" is

src/index.js Outdated Show resolved Hide resolved
src/notify.js Show resolved Hide resolved
src/notify.js Show resolved Hide resolved
src/webhooknotify.js Outdated Show resolved Hide resolved
src/webhooknotify.js Outdated Show resolved Hide resolved
@bernes1 bernes1 merged commit 303cdd3 into main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants