Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DH-394] fix publichealth #5

Merged
merged 5 commits into from
Oct 10, 2024
Merged

[DH-394] fix publichealth #5

merged 5 commits into from
Oct 10, 2024

Conversation

felder
Copy link
Contributor

@felder felder commented Oct 10, 2024

@shaneknapp
Copy link
Contributor

i'm gonna build this locally and see what happens... :)

shaneknapp
shaneknapp approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@shaneknapp shaneknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this look good, and builds successfully, but due to the scope of the changes i'd feel best if @balajialg has some notebooks to test on staging before we merge to prod.

@balajialg
Copy link
Contributor

okay, let me do some testing in the staging hub and report back!

@shaneknapp
Copy link
Contributor

okay, let me do some testing in the staging hub and report back!

btw, this hasn't been deployed to staging yet

@shaneknapp
Copy link
Contributor

@balajialg if the changes look good to you, approve the PR and then merge. after it builds and pushes a commit to the datahub repo, we can merge that and you can test on staging

ryanlovett
ryanlovett reviewed Oct 10, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
balajialg
balajialg approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@balajialg balajialg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do some testing for PH 142, 251 and 253 notebooks when the changes gets merged to staging. Thanks for the heads up @shaneknapp !

@shaneknapp
Copy link
Contributor

LGTM! feel free to merge

@felder felder merged commit 34f76c1 into berkeley-dsep-infra:main Oct 10, 2024
2 checks passed
@felder felder deleted the felder_DH-394 branch October 10, 2024 19:10
@felder
Copy link
Contributor Author

felder commented Oct 10, 2024

Issue berkeley-dsep-infra/datahub#6349

@felder felder mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanlovett ryanlovett ryanlovett left review comments

@balajialg balajialg balajialg approved these changes

@shaneknapp shaneknapp shaneknapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felder @shaneknapp @balajialg @ryanlovett