Skip to content

Commit

Permalink
Merge pull request #5501 from shaneknapp/potential-chp-fix
Browse files Browse the repository at this point in the history
[DH-3] try using a test fork of the chp
  • Loading branch information
shaneknapp authored Feb 27, 2024
2 parents afcb168 + f928307 commit 05bfa15
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 3 deletions.
2 changes: 1 addition & 1 deletion hub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ apiVersion: v1
appVersion: '1.0'
description: Deployment Chart for JupyterHub
name: hub
version: 0.0.1-0.dev.git.7370.h98d3927c
version: 0.0.1-0.dev.git.7435.hd97afe24
16 changes: 15 additions & 1 deletion hub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,28 @@ jupyterhub:
service:
type: ClusterIP
chp:
# testing out a potential fix for the chp leaking ports
# https://github.com/jupyterhub/configurable-http-proxy/issues/434
# https://github.com/jupyterhub/configurable-http-proxy/issues/434#issuecomment-1924261459
# https://github.com/http-party/node-http-proxy/pull/1559
# https://github.com/Jimbly/http-proxy-node16/commit/56283e33edfc7aad8c2605dd493da8a196b4371d
# https://github.com/consideRatio/configurable-http-proxy/commits/main/
#
image:
tag: 4.6.1-fork
extraCommandLineFlags:
# set the timeout and proxyTimeout to 24 hours (arg is in milliseconds)
# https://github.com/http-party/node-http-proxy?tab=readme-ov-file#options
# - "--timeout=86400000"
# - "--proxy-timeout=86400000"
resources:
requests:
# FIXME: We want no guarantees here!!!
# This is lowest possible value
cpu: 0.001
memory: 64Mi
limits:
memory: 1Gi
memory: 1.5Gi
traefik:
resources:
requests:
Expand Down
2 changes: 1 addition & 1 deletion node-placeholder/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.0.1-0.dev.git.7305.h0a2e62d9
version: 0.0.1-0.dev.git.7434.h9c1949f1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down

0 comments on commit 05bfa15

Please sign in to comment.