[DH-384] moving the pydantic package def below otter-grader fixes import spacy
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after checking out the |
shaneknapp
changed the title
pydantic import below otter-grader fixes import spacypydantic package def below otter-grader fixes import spacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also:
explosion/spaCy#12669
explosion/spaCy#12659
ordering the imports this way means that the version of
pydanticthat is installed (<2.X) doesn't break spacy.from looking at
pipdeptreewhenspacywasn't working, it looks likeotter-graderwas pulling in v2.10.X ofpydantic.@sean-morris any insights in to what
otter-graderneeds in this context? i was able to execute theotterbinary on my local build w/o any errors, but you're most definitely the experten here.