Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Student Room Preference #29

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Feat: Student Room Preference #29

merged 6 commits into from
Dec 2, 2023

Conversation

Reimirno
Copy link

@Reimirno Reimirno commented Dec 2, 2023

We now can set students to want or avoid certain rooms. Such preference would be respected by the seat assigning algorithm.

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for unit tests for Python 3.10
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py821779%17–20, 43–45, 58–61, 93–98
   models.py1533378%28, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
   views.py33626122%31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py252020%16–58
   data.py1231138%9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
   __init__.py302130%18–59
   smtp.py411173%15, 28–30, 32–34, 50–53
server/services/email/templates
   __init__.py33197%20
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py25964%16–29, 35, 41–42, 51, 54
server/utils
   date.py7443%17–19, 30
   misc.py6517%5–9
TOTAL124968046% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 5.607s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for unit tests for Python 3.11
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py821779%17–20, 43–45, 58–61, 93–98
   models.py1533378%28, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
   views.py33626122%31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py252020%16–58
   data.py1231138%9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
   __init__.py302130%18–59
   smtp.py411173%15, 28–30, 32–34, 50–53
server/services/email/templates
   __init__.py33197%20
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py25964%16–29, 35, 41–42, 51, 54
server/utils
   date.py7443%17–19, 30
   misc.py6517%5–9
TOTAL124968046% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 0.636s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for e2e tests for Python 3.10
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py821779%17–20, 43–45, 58–61, 93–98
   models.py1533577%27–30, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
   views.py33626122%31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py252020%16–58
   data.py1231138%9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
   __init__.py302130%18–59
   smtp.py412929%15, 23–53
server/services/email/templates
   __init__.py332330%9–11, 14–17, 20, 30–41, 45–47
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py25964%16–29, 35, 41–42, 51, 54
server/utils
   date.py7443%17–19, 30
   misc.py6517%5–9
TOTAL124973541% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 18.539s ⏱️

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (2102f80) 46.34% compared to head (d3da4de) 45.55%.

Files Patch % Lines
server/views.py 4.16% 23 Missing ⚠️
server/models.py 45.45% 6 Missing ⚠️
server/services/core/data.py 0.00% 5 Missing ⚠️
server/typings/exception.py 37.50% 5 Missing ⚠️
server/forms.py 69.23% 4 Missing ⚠️
server/services/core/assign.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   46.34%   45.55%   -0.79%     
==========================================
  Files          22       22              
  Lines        1204     1249      +45     
==========================================
+ Hits          558      569      +11     
- Misses        646      680      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for e2e tests for Python 3.11
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py821779%17–20, 43–45, 58–61, 93–98
   models.py1533577%27–30, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
   views.py33626122%31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py252020%16–58
   data.py1231138%9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
   __init__.py302130%18–59
   smtp.py412929%15, 23–53
server/services/email/templates
   __init__.py332330%9–11, 14–17, 20, 30–41, 45–47
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py25964%16–29, 35, 41–42, 51, 54
server/utils
   date.py7443%17–19, 30
   misc.py6517%5–9
TOTAL124973541% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 19.572s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for unit tests for Python 3.12
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py821779%17–20, 43–45, 58–61, 93–98
   models.py1533378%28, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
   views.py33626122%31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py252020%16–58
   data.py1231138%9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
   __init__.py302130%18–59
   smtp.py411173%15, 28–30, 32–34, 50–53
server/services/email/templates
   __init__.py33197%20
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py25964%16–29, 35, 41–42, 51, 54
server/utils
   date.py7443%17–19, 30
   misc.py6517%5–9
TOTAL124968046% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 5.771s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for e2e tests for Python 3.12
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py821779%17–20, 43–45, 58–61, 93–98
   models.py1533577%27–30, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
   views.py33626122%31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py252020%16–58
   data.py1231138%9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
   __init__.py302130%18–59
   smtp.py412929%15, 23–53
server/services/email/templates
   __init__.py332330%9–11, 14–17, 20, 30–41, 45–47
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py25964%16–29, 35, 41–42, 51, 54
server/utils
   date.py7443%17–19, 30
   misc.py6517%5–9
TOTAL124973541% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 33.531s ⏱️

@Reimirno Reimirno merged commit 2c73f20 into main Dec 2, 2023
14 of 16 checks passed
@Reimirno Reimirno deleted the student-room-preference branch December 2, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant