Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Email Preview and Editor #25

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Feat: Email Preview and Editor #25

merged 4 commits into from
Dec 2, 2023

Conversation

Reimirno
Copy link

@Reimirno Reimirno commented Dec 2, 2023

Allow emailed status display and re-send email.

image

Allow CC and BCC.
Email content editor and preview.
To, CC, BCC all support comma-separated email list.

image

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for unit tests for Python 3.11
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py671381%18–21, 42–44, 76–81
   models.py1212282%27, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py28421325%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–253, 259–283, 289–306, 313, 318–320, 325–349, 354–359, 364–374, 379–394, 399–414, 424, 429, 434, 442–443, 449, 454–458
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py95887%8–56, 60, 64–77, 81–116
server/services/email
   __init__.py322328%18–55
   smtp.py411173%15, 28–30, 32–34, 50–53
server/services/email/templates
   __init__.py33197%20
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL111058747% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 0.636s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for unit tests for Python 3.10
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py671381%18–21, 42–44, 76–81
   models.py1212282%27, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py28421325%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–253, 259–283, 289–306, 313, 318–320, 325–349, 354–359, 364–374, 379–394, 399–414, 424, 429, 434, 442–443, 449, 454–458
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py95887%8–56, 60, 64–77, 81–116
server/services/email
   __init__.py322328%18–55
   smtp.py411173%15, 28–30, 32–34, 50–53
server/services/email/templates
   __init__.py33197%20
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL111058747% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 0.632s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for e2e tests for Python 3.10
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py671381%18–21, 42–44, 76–81
   models.py1212480%26–29, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py28421325%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–253, 259–283, 289–306, 313, 318–320, 325–349, 354–359, 364–374, 379–394, 399–414, 424, 429, 434, 442–443, 449, 454–458
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py95887%8–56, 60, 64–77, 81–116
server/services/email
   __init__.py322328%18–55
   smtp.py412929%15, 23–53
server/services/email/templates
   __init__.py332330%9–11, 14–17, 20, 30–41, 45–47
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL111064242% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 18.929s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for e2e tests for Python 3.11
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py671381%18–21, 42–44, 76–81
   models.py1212480%26–29, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py28421325%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–253, 259–283, 289–306, 313, 318–320, 325–349, 354–359, 364–374, 379–394, 399–414, 424, 429, 434, 442–443, 449, 454–458
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py95887%8–56, 60, 64–77, 81–116
server/services/email
   __init__.py322328%18–55
   smtp.py412929%15, 23–53
server/services/email/templates
   __init__.py332330%9–11, 14–17, 20, 30–41, 45–47
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL111064242% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 18.416s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for unit tests for Python 3.12
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py671381%18–21, 42–44, 76–81
   models.py1212282%27, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py28421325%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–253, 259–283, 289–306, 313, 318–320, 325–349, 354–359, 364–374, 379–394, 399–414, 424, 429, 434, 442–443, 449, 454–458
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py95887%8–56, 60, 64–77, 81–116
server/services/email
   __init__.py322328%18–55
   smtp.py411173%15, 28–30, 32–34, 50–53
server/services/email/templates
   __init__.py33197%20
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL111058747% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 6.691s ⏱️

Copy link

github-actions bot commented Dec 2, 2023

Coverage

Coverage for e2e tests for Python 3.12
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py671381%18–21, 42–44, 76–81
   models.py1212480%26–29, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py28421325%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–253, 259–283, 289–306, 313, 318–320, 325–349, 354–359, 364–374, 379–394, 399–414, 424, 429, 434, 442–443, 449, 454–458
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py95887%8–56, 60, 64–77, 81–116
server/services/email
   __init__.py322328%18–55
   smtp.py412929%15, 23–53
server/services/email/templates
   __init__.py332330%9–11, 14–17, 20, 30–41, 45–47
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL111064242% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 29.739s ⏱️

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (9bee861) 47.37% compared to head (192c98a) 47.11%.

Files Patch % Lines
server/services/email/__init__.py 8.00% 23 Missing ⚠️
server/views.py 12.00% 22 Missing ⚠️
server/services/email/smtp.py 30.76% 9 Missing ⚠️
server/forms.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   47.37%   47.11%   -0.26%     
==========================================
  Files          21       21              
  Lines        1085     1110      +25     
==========================================
+ Hits          514      523       +9     
- Misses        571      587      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Reimirno Reimirno requested a review from cycomachead December 2, 2023 01:10
@Reimirno Reimirno merged commit 7fd6335 into main Dec 2, 2023
14 of 16 checks passed
@Reimirno Reimirno deleted the better-email branch December 2, 2023 06:45
Copy link

sentry-io bot commented Dec 10, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SystemExit: 1 email_all_students View Issue
  • ‼️ SystemExit: 1 email_all_students View Issue
  • ‼️ SystemExit: 1 email_all_students View Issue
  • ‼️ SystemExit: 1 email_all_students View Issue

Did you find this useful? React with a 👍 or 👎

@Reimirno
Copy link
Author

Did the N+1 Db query crashed the server or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant