Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Better Course Offering List #21

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Feat: Better Course Offering List #21

merged 3 commits into from
Nov 30, 2023

Conversation

Reimirno
Copy link

@Reimirno Reimirno commented Nov 30, 2023

This PR improved the course list. Now we:

  • Sort the course list by course.start_at_start DESC then course.name ASC
  • Display course.start_at_start for each course in addition to its name.

This is what it looks like:
image

Take note:

This PR contains a db schema change. Run flask resetdb on heroku to recreate staging db after this is merged.

@Reimirno Reimirno linked an issue Nov 30, 2023 that may be closed by this pull request
Copy link

Coverage

Coverage for unit tests for Python 3.11
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py59788%19–22, 43–45
   models.py1212282%27, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py24317528%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–242, 248–261, 267–284, 291, 296–298, 303–327, 332–337, 342–350, 355–361, 370, 375, 380, 388–389, 395, 400–404
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py86798%8–56, 60, 64–77, 81–105
server/services/email
   __init__.py352529%18–46, 50–68
   smtp.py31390%15, 39–40
server/services/email/templates
   __init__.py27196%14
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL104352849% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 0.586s ⏱️

Copy link

Coverage

Coverage for unit tests for Python 3.10
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py59788%19–22, 43–45
   models.py1212282%27, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py24317528%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–242, 248–261, 267–284, 291, 296–298, 303–327, 332–337, 342–350, 355–361, 370, 375, 380, 388–389, 395, 400–404
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py86798%8–56, 60, 64–77, 81–105
server/services/email
   __init__.py352529%18–46, 50–68
   smtp.py31390%15, 39–40
server/services/email/templates
   __init__.py27196%14
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL104352849% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 5.663s ⏱️

Copy link

Coverage

Coverage for unit tests for Python 3.12
FileStmtsMissCoverMissing
server
   __init__.py42490%20–21, 46, 54
   forms.py59788%19–22, 43–45
   models.py1212282%27, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py24317528%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–242, 248–261, 267–284, 291, 296–298, 303–327, 332–337, 342–350, 355–361, 370, 375, 380, 388–389, 395, 400–404
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13285%17–18
server/services/auth
   __init__.py28486%21, 49, 54–55
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py86798%8–56, 60, 64–77, 81–105
server/services/email
   __init__.py352529%18–46, 50–68
   smtp.py31390%15, 39–40
server/services/email/templates
   __init__.py27196%14
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL104352849% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 0.609s ⏱️

Copy link

Coverage

Coverage for e2e tests for Python 3.10
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py59788%19–22, 43–45
   models.py1212480%26–29, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py24317528%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–242, 248–261, 267–284, 291, 296–298, 303–327, 332–337, 342–350, 355–361, 370, 375, 380, 388–389, 395, 400–404
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py86798%8–56, 60, 64–77, 81–105
server/services/email
   __init__.py352529%18–46, 50–68
   smtp.py311939%15, 19–40
server/services/email/templates
   __init__.py271833%9–11, 14, 24–34, 38–40
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL104357645% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 18.192s ⏱️

Copy link

Coverage

Coverage for e2e tests for Python 3.11
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py59788%19–22, 43–45
   models.py1212480%26–29, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py24317528%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–242, 248–261, 267–284, 291, 296–298, 303–327, 332–337, 342–350, 355–361, 370, 375, 380, 388–389, 395, 400–404
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py86798%8–56, 60, 64–77, 81–105
server/services/email
   __init__.py352529%18–46, 50–68
   smtp.py311939%15, 19–40
server/services/email/templates
   __init__.py271833%9–11, 14, 24–34, 38–40
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL104357645% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 18.552s ⏱️

Copy link

Coverage

Coverage for e2e tests for Python 3.12
FileStmtsMissCoverMissing
server
   __init__.py421076%12, 15–21, 26, 46, 54
   forms.py59788%19–22, 43–45
   models.py1212480%26–29, 55, 58, 61, 87, 91, 94–103, 106, 126–127, 133, 151, 170, 173, 187
   views.py24317528%29–34, 47–48, 66–84, 95–97, 106–113, 122, 133–135, 145–162, 172–189, 200–204, 213–215, 223–225, 231–242, 248–261, 267–284, 291, 296–298, 303–327, 332–337, 342–350, 355–361, 370, 375, 380, 388–389, 395, 400–404
server/controllers
   __init__.py653743%25–52, 55, 66–86, 89
   auth_controllers.py382534%13–15, 21–47, 53–55
   dev_login_controllers.py342332%11–25, 30–39, 44–56
   health_controllers.py13746%8, 13–18
server/services/auth
   __init__.py28679%21, 49, 54–55, 60–61
server/services/canvas
   __init__.py513531%18–25, 29, 33, 37, 47–80, 84
   fake_canvas.py392633%9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
   assign.py292610%14–62
   data.py86798%8–56, 60, 64–77, 81–105
server/services/email
   __init__.py352529%18–46, 50–68
   smtp.py311939%15, 19–40
server/services/email/templates
   __init__.py271833%9–11, 14, 24–34, 38–40
server/services/google
   __init__.py542946%23, 31, 33, 41–44, 48–54, 58–77
server/typings
   exception.py17476%17–18, 27, 30
server/utils
   date.py3167%12
TOTAL104357645% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 26.626s ⏱️

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (73c76f4) 49.56% compared to head (17f1814) 49.37%.

Files Patch % Lines
server/services/canvas/__init__.py 0.00% 9 Missing ⚠️
server/services/canvas/fake_canvas.py 33.33% 2 Missing ⚠️
server/models.py 80.00% 1 Missing ⚠️
server/utils/date.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   49.56%   49.37%   -0.19%     
==========================================
  Files          20       21       +1     
  Lines        1027     1043      +16     
==========================================
+ Hits          509      515       +6     
- Misses        518      528      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Reimirno Reimirno merged commit 53f0a38 into main Nov 30, 2023
14 of 16 checks passed
@Reimirno Reimirno deleted the sort-courses branch November 30, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bCourses list of courses from canvas sorting
1 participant