windows 10 compatibility #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Eli, The latest updates here look good. I have pulled the latest revision and tested on my linux box to make sure there are no breaking changes, looks all good. Do you think there is much more to do to close out the functionality you wanted to add? One request i do have - in your latest commit - 8a5b9ab - you included the generated files for one of the examples. Could you roll this commit back to clean up these files? I also think it would be good to have an example project with the new cflags options, have you got something simple you are using for testing which could be added? Cheers, |
|
I want to but I don't know how to roll this commit back. Sorry09.04.2019, 23:30, "Ben Marshall" <[email protected]>:Hi Eli,
The latest updates here look good. I have pulled the latest revision and tested on my linux box to make sure there are no breaking changes, looks all good.
Do you think there is much more to do to close out the functionality you wanted to add?
One request i do have - in your latest commit - 8a5b9ab - you included the generated files for one of the examples. Could you roll this commit back to clean up these files?
I also think it would be good to have an example project with the new cflags options, have you got something simple you are using for testing which could be added?
Cheers,
Ben
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
|
instead, I have done some minor cleanup. 17.04.2019, 22:51, "Joe Chan" <[email protected]>:I want to but I don't know how to roll this commit back. Sorry09.04.2019, 23:30, "Ben Marshall" <[email protected]>:Hi Eli,
The latest updates here look good. I have pulled the latest revision and tested on my linux box to make sure there are no breaking changes, looks all good.
Do you think there is much more to do to close out the functionality you wanted to add?
One request i do have - in your latest commit - 8a5b9ab - you included the generated files for one of the examples. Could you roll this commit back to clean up these files?
I also think it would be good to have an example project with the new cflags options, have you got something simple you are using for testing which could be added?
Cheers,
Ben
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor modifications to make it compatible to windows 10
Eli