Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature
Added authentication for proxies and changed settings because you don't need multiple proxies; just one.
What it does
Short: Two things. First, it changes the way proxies are set up so that you no longer have 6 settings for your proxy configuration but 3 (+2 for authentication). You can now set your proxy type and just go on whit host and password. Whit authentication there would have been to many setting entries in my eyes.
Secondly (the main purpose) it adds a way to add the proxy authentication in the settings using the
Why do I want that feature?
I need this feature in the program because my Teacher wants to use it in our school and I don't want to manually search and install every library I want. I will also create a pr for a hopefully portable version of the app by moving the settings into the app or (more likely) creating a file inside of the app containing the path to the settings file (needed because %AppData% resets every time rebooting a school PC). Please tell me if you have a solution in mind so I can build it to your wishes.
Sidenotes
handleProxy
into theinit
method but I thought I better leave it. If you want it its done in seconds.Draft
The proxy authentication still needs testing, I only found a public http proxy whit out authentication to test it. That is why its still a draft; I need someone to test it please (I can first test it by next Thursday).