Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Cargo optional MB/s output #255

Closed

Conversation

seanmonstar
Copy link

In a Rust benchmark, if you specify how many bytes a benchmark is touching, it can output MB/s. This parses and ignores that value.

@ktrz
Copy link
Member

ktrz commented Sep 9, 2024

Thank you for your contribution! Could you please add a test case with the MB/s unit that was failing and is passing now?

@xtrm0
Copy link
Contributor

xtrm0 commented Nov 27, 2024

Maybe it would make more sense to support arbitrary units instead and extract the unit?

I have a test on this format that fails, for instance:

test cmov ... bench:        2835 cycles/iter (+/- 14)
test cmov2 ... bench:        2845 cycles/iter (+/- 19)
test mov ... bench:        1508 cycles/iter (+/- 17)

@xtrm0
Copy link
Contributor

xtrm0 commented Nov 27, 2024

I added support for these changes in #280

@ktrz
Copy link
Member

ktrz commented Dec 9, 2024

resolved by #280

@ktrz ktrz closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants