Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Comment on PR and auto update comment #223

Merged
merged 35 commits into from
Mar 28, 2024
Merged

Conversation

ktrz
Copy link
Member

@ktrz ktrz commented Jan 31, 2024

  • create PR comment when PR is available

closes #98

@ktrz ktrz self-assigned this Jan 31, 2024
github-actions[bot]

This comment was marked as outdated.

ktrz added 6 commits February 2, 2024 10:01
* create PR comment when PR is available
* add gh token to workflow
* create review instead of review comment
* disable unnecessary ci runs
* add pr write permissions
* remove pending review
@ktrz ktrz force-pushed the feat/98-autoupdate-pr-comment branch from d64c4b6 to 0ee988e Compare February 2, 2024 09:08
github-actions[bot]

This comment was marked as outdated.

ktrz added 2 commits February 2, 2024 13:41
* revert removing pending review
* add logic for updating comment
github-actions[bot]

This comment was marked as outdated.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
BenchmarkFib10 310.3 ns/op 310.7 ns/op 1.00
BenchmarkFib20 39602 ns/op 39528 ns/op 1.00
BenchmarkFib20WithAuxMetric 39878 ns/op 4.000 auxMetricUnits 39638 ns/op 4.000 auxMetricUnits 1.01
BenchmarkFib20WithAuxMetric - ns/op 39878 ns/op 39638 ns/op 1.01
BenchmarkFib20WithAuxMetric - auxMetricUnits 4 auxMetricUnits 4 auxMetricUnits 1

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark.js Benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
fib(10) 1666682 ops/sec (±0.18%) 1614900 ops/sec (±0.33%) 0.97
fib(20) 13521 ops/sec (±0.24%) 13365 ops/sec (±0.17%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python Benchmark with pytest-benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
bench.py::test_fib_10 76639.10714283153 iter/sec (stddev: 8.032532335846265e-7) 76322.25409653576 iter/sec (stddev: 0.0000010082750379909067) 1.00
bench.py::test_fib_20 615.4022089304406 iter/sec (stddev: 0.000012812298584847541) 620.0468031518758 iter/sec (stddev: 0.00001294268552372628) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ Benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
fib_10 158.5494359313285 ns/iter 158.5773734900016 ns/iter 1.00
fib_20 20255.732813970742 ns/iter 21280.30560862275 ns/iter 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catch2 Benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
Fibonacci 10 145 ns (± 4) 145 ns (± 1) 1
Fibonacci 20 18.803 us (± 325) 18.788 us (± 210) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JMH Benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
org.openjdk.jmh.samples.JMHSample_01_HelloWorld.wellHelloThere 1971960426.4295356 ops/s 1976042355.4545352 ops/s 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark.Net Benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
Sample.Benchmarks.Fib10 21.02941538508122 ns (± 0.11769825051195898) 21.052492980773632 ns (± 0.023515474146354454) 1.00
Sample.Benchmarks.Fib20 42.51694103678067 ns (± 0.22967208645508033) 42.762034581257744 ns (± 0.07720966000547073) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@ktrz ktrz linked an issue Feb 2, 2024 that may be closed by this pull request
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
bench_fib_10 175 ns/iter (± 1) 175 ns/iter (± 1) 1
bench_fib_20 22180 ns/iter (± 176) 22175 ns/iter (± 3292) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Criterion.rs Benchmark

Benchmark suite Current: 49be1e5 Previous: a6c4f1c Ratio
BenchFib10 150 ns/iter (± 24) 149 ns/iter (± 19) 1.01
BenchFib20 18804 ns/iter (± 155) 18804 ns/iter (± 2088) 1
Fibonacci/Recursive/20 18818 ns/iter (± 1231) 18809 ns/iter (± 345) 1.00
Fibonacci/Iterative/20 3 ns/iter (± 0) 4 ns/iter (± 0) 0.75
Fibonacci/Recursive/21 30448 ns/iter (± 41) 30435 ns/iter (± 57) 1.00
Fibonacci/Iterative/21 4 ns/iter (± 0) 4 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

@ktrz ktrz marked this pull request as ready for review March 27, 2024 09:40
@ktrz ktrz requested a review from ningziwen March 27, 2024 09:40
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Benchmark.js Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 362fe82 Previous: a6c4f1c Ratio
fib(10) 13323 ops/sec (±0.41%) 1614900 ops/sec (±0.33%) 121.21

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Benchmark.Net Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 362fe82 Previous: a6c4f1c Ratio
Sample.Benchmarks.Fib10 42.24651443106787 ns (± 0.24835811309062725) 21.052492980773632 ns (± 0.023515474146354454) 2.01

This comment was automatically generated by workflow using github-action-benchmark.

@ktrz ktrz changed the title feat: auto update PR comment feat: Comment on PR and auto update comment Mar 28, 2024
@ktrz ktrz merged commit f65fed8 into master Mar 28, 2024
24 checks passed
@ktrz ktrz deleted the feat/98-autoupdate-pr-comment branch March 28, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Auto-updated PR comment
1 participant