-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve readme and update minimal example #198
base: master
Are you sure you want to change the base?
Conversation
@@ -83,61 +88,10 @@ context) properties. Like this: | |||
] | |||
``` | |||
|
|||
## Screenshots | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this introduction has some value to users to understand the tool. If we don't want to distract in the main doc, we can move it to separated doc and link it here. Completely deleting it may create the gap and user experience regression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshots are still there, but I moved them to the very top (except this one https://raw.githubusercontent.com/rhysd/ss/master/github-action-benchmark/tooltip.png which I feel adds no value - people using this tool will notice on their own about this, and people that don't yet know this tool will not care about this detail).
Please checkout the readme locally and see how it looks
run: git push 'https://you:${{ secrets.GITHUB_TOKEN }}@github.com/you/repo-name.git' gh-pages:gh-pages | ||
``` | ||
|
||
Please add a step to push the branch to the remote. | ||
|
||
|
||
### Tool specific setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. These have value to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is repeated thrice.
- https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#github-action-for-continuous-benchmarking
- and here https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#tool-specific-setup
- and here https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#examples
I put everything in one place (the table). Please checkout the readme locally and see how it looks
Changes: