Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readme and update minimal example #198

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Oct 20, 2023

Changes:

  • The current README is too verbose, IMO. I condensed it.
  • Updated the versions of some github actions used.
  • Updated the minimal example workflow

⚠️ Suggestion to reviewers: checkout the PR locally and see the end result of the README

.github/workflows/minimal.yml Outdated Show resolved Hide resolved
.github/workflows/minimal.yml Outdated Show resolved Hide resolved
.github/workflows/minimal.yml Outdated Show resolved Hide resolved
@@ -83,61 +88,10 @@ context) properties. Like this:
]
```

## Screenshots

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this introduction has some value to users to understand the tool. If we don't want to distract in the main doc, we can move it to separated doc and link it here. Completely deleting it may create the gap and user experience regression.

Copy link
Contributor Author

@miparnisari miparnisari Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots are still there, but I moved them to the very top (except this one https://raw.githubusercontent.com/rhysd/ss/master/github-action-benchmark/tooltip.png which I feel adds no value - people using this tool will notice on their own about this, and people that don't yet know this tool will not care about this detail).

Please checkout the readme locally and see how it looks

run: git push 'https://you:${{ secrets.GITHUB_TOKEN }}@github.com/you/repo-name.git' gh-pages:gh-pages
```

Please add a step to push the branch to the remote.


### Tool specific setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. These have value to users.

Copy link
Contributor Author

@miparnisari miparnisari Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ningziwen ningziwen requested a review from ktrz December 27, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants