Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo-criterion tool support #145

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

brainstorm
Copy link

@brainstorm brainstorm commented Dec 22, 2022

After struggling with cargo bench integration with criterion-rs and this action, I've decided to add support for cargo criterion which adds improvements in several areas vs the plain criterion-rs bench+plaintext extract approach.

Here are some examples of the outputs generated by this PR:

https://umccr.github.io/htsget-rs/dev/bench/ <--- generated by this action
https://umccr.github.io/htsget-rs/dev/bench/native/criterion/reports/ <--- generated by cargo-criterion natively and pushed to gh-pages branch as-is.

/cc @mmalenic

@brainstorm brainstorm mentioned this pull request Jan 5, 2023
@brainstorm brainstorm marked this pull request as ready for review January 5, 2023 01:50
@dclong
Copy link

dclong commented Feb 15, 2023

When cargo criterion output benchmark results for multiple functions, it seems that only one of them is included? Is it possible to parse all benchmark results from the output of cargo criterion?

@brainstorm
Copy link
Author

When cargo criterion output benchmark results for multiple functions, it seems that only one of them is included? Is it possible to parse all benchmark results from the output of cargo criterion?

Oh, sorry about that, can you point me in the code or show me some errors where you are having issues? IIRC it works for our multiple cargo criterion benchmark outputs, so I need a bit more details to diagnose this issue...

@mothran mothran mentioned this pull request Feb 23, 2023
2 tasks
@GitGab19
Copy link

GitGab19 commented Aug 8, 2023

When cargo criterion output benchmark results for multiple functions, it seems that only one of them is included? Is it possible to parse all benchmark results from the output of cargo criterion?

I'm still getting the same issue here.
You can have a look at my workflow execution here: https://github.com/GitGab19/stratum/actions/runs/5795828071/job/15708142675
And here what it's generated from this action: https://gitgab19.github.io/stratum/dev/bench/

@epompeii
Copy link
Contributor

If anyone else is blocked by this, Bencher supports Criterion: https://github.com/bencherdev/bencher#supported-benchmark-harnesses

@xtrm0
Copy link
Contributor

xtrm0 commented Nov 27, 2024

If anyone else is blocked by this, cargo-criterion supports outputing in cargo bench format:

cargo criterion --output-format bencher 2>&1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants