Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in Cargo.lock #23

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Check in Cargo.lock #23

merged 1 commit into from
Feb 3, 2024

Conversation

cbarrete
Copy link
Collaborator

@cbarrete cbarrete commented Feb 3, 2024

  • The guidelines around checking in Cargo.lock files for executables have changed, it is not discouraged anymore
  • This gives a known good state for building/installing via --locked
  • This enables reproducible packaging e.g. with Nix

I'll write the Nix package if you release this as 1.1.0 :)

- The guidelines around checking in Cargo.lock files for executables
  have changed, it is not discouraged anymore
- This gives a known good state for building/installing via `--locked`
- This enables reproducible packaging e.g. with Nix
@benbrittain
Copy link
Owner

It's always been good to check in Cargo.lock for executables, it's embarrassing I didn't. Done.

@benbrittain benbrittain merged commit 33bf9e2 into benbrittain:main Feb 3, 2024
1 check passed
@benbrittain
Copy link
Owner

Release of 1.1.0 has been triggered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants