detect macos as darwin #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function returns BUCKLE_HOME or similar, not the dir buck2 is unpacked in testes with cargo test
updated test case tested via cargo test
use the github archive url information so we only download things it claims to have removed the now unused BASE_URL constant
As per https://doc.rust-lang.org/stable/rustc/platform-support.html, macos is known as darwin in the target triples
This was referenced Jun 25, 2023
Closed
benbrittain
force-pushed
the
main
branch
5 times, most recently
from
7e637a9 to
b90a5cc
Compare
|
looks like this was included in a45d2c8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detect macos as darwin
As per https://doc.rust-lang.org/stable/rustc/platform-support.html, macos is known as darwin in the target triples
Stack created with Sapling. Best reviewed with ReviewStack.