improve the way frames_per_sample are computed when using auto_width #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that for long audio files, the previous solution produced waveforms which ran slower than the audio file. So here is an update:
Previously the frames_per_sample depended on the width, and thus for long audio the visual representation of the waveform could be "slower" than the actual audio. Now we'll set the samples_pre_frame based on the audio's sample_rate, so the waveform will match the audio.