Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the way frames_per_sample are computed when using auto_width #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mreinsch
Copy link
Contributor

I noticed that for long audio files, the previous solution produced waveforms which ran slower than the audio file. So here is an update:

Previously the frames_per_sample depended on the width, and thus for long audio the visual representation of the waveform could be "slower" than the actual audio. Now we'll set the samples_pre_frame based on the audio's sample_rate, so the waveform will match the audio.

Previously the frames_per_sample depended on the width, and thus for long audio the visual representation of the waveform could be "slower" than the actual audio. Now we'll set the samples_pre_frame based on the audio's sample_rate, so the waveform will match the audio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant