Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #13 Import OxyPlot.Blazor.js from root (absolute import) #14

Closed
wants to merge 1 commit into from

Conversation

phuongdoan13
Copy link

No description provided.

@phuongdoan13 phuongdoan13 changed the title #13 Import OxyPlot.Blazor.js from root (absolute import) Resolve #13 Import OxyPlot.Blazor.js from root (absolute import) Sep 4, 2023
@phuongdoan13
Copy link
Author

Hi @belucha, thank you for your awesome library. Please find my proposal to resolve issue #13

@belucha
Copy link
Owner

belucha commented Sep 5, 2023

@phuongdoan13 thank you for the merge request, which seems reasonable.
However I do not understand yet fully, why this does not work, since it follows the MS recomendations.

https://learn.microsoft.com/en-us/aspnet/core/blazor/components/class-libraries?view=aspnetcore-7.0&tabs=visual-studio#create-an-rcl-with-javascript-files-collocated-with-components

They explicitly have the leading ./_content/... part in the import statement.

Do you have any hints for me?

@belucha belucha self-assigned this Sep 5, 2023
@phuongdoan13
Copy link
Author

Hi @belucha, thank you for your patience, thank you for your patience. After discussing with the team, we figured out that we didn't have in our _Host.cshtml :) Nothing wrong with your code.

@phuongdoan13
Copy link
Author

I have another question. It seems to me that this package on nuget is not strongly signed, which causes us a lot of trouble integrating it into the system. I wonder if there is any reason to not sign it.

@belucha
Copy link
Owner

belucha commented Jan 24, 2024

I investigated some short time in strongly signing and did not have success.
I don't see other libraries like MudBlazor strongly signed either.
Besides I will close this pull request since it is unrelated anyway.

@belucha belucha closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants