Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PySide6 AppImage testing. #150

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

freakboy3742
Copy link
Member

Fixes beeware/briefcase#1908.

AppImage support is explicitly best-effort at this point; since PySide6 support is causing problems, it gets put into the "ignored" pile.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 force-pushed the deprecate-pyside6-appimage branch 3 times, most recently from b965109 to a85b21a Compare July 11, 2024 04:27
@freakboy3742 freakboy3742 force-pushed the deprecate-pyside6-appimage branch from a85b21a to 7d7e65b Compare July 11, 2024 04:29
@freakboy3742 freakboy3742 requested a review from rmartin16 July 11, 2024 04:47
@freakboy3742 freakboy3742 mentioned this pull request Jul 11, 2024
4 tasks
Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was a little surprised the most recent CI run for briefcase-linux-appimage-template did not fail. I guess that may imply the root cause is not PySide6 itself...

@rmartin16 rmartin16 merged commit df220fe into main Jul 11, 2024
71 checks passed
@rmartin16 rmartin16 deleted the deprecate-pyside6-appimage branch July 11, 2024 16:36
@freakboy3742
Copy link
Member Author

Looks good. I was a little surprised the most recent CI run for briefcase-linux-appimage-template did not fail. I guess that may imply the root cause is not PySide6 itself...

My guess would be that the culprit is Applmage/LinuxDeploy. They don't tag their releases, and use a continuous release strategy, so it's really easy for bugs to slip in and have no evidence for it. The Qt plugin is also compiled, so it's another source of segfaulting errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppImages running PySide6>=6.6.2 immediately seg fault
2 participants