Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce action for setting up running Android emulator #133

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented May 19, 2024

Changes

  • Consolidates necessary logic for running the Android emulator in a GitHub action
  • Outputs the necessary briefcase run android args to run the emulator in CI

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the setup-android branch 5 times, most recently from 971c9b8 to c25390a Compare May 21, 2024 19:59
@rmartin16
Copy link
Member Author

This PR includes implementing this new GitHub action in app-build-verify but it will also need to be implemented in Toga's CI and Python-support-testbed's CI. Once the new beeware/actions repo is running, it'll use this as well.

@rmartin16 rmartin16 marked this pull request as ready for review May 21, 2024 20:04
@rmartin16 rmartin16 requested a review from freakboy3742 May 21, 2024 20:04
@freakboy3742
Copy link
Member

@rmartin16 I just noticed this PR had slipped through the review cracks. My initial impression is that it makes sense - any recollection why (beyond "analogous changes needed in Toga etc") this was a draft?

@rmartin16
Copy link
Member Author

This was part of (another one of..) my experiment for creating public-facing GitHub Actions. As part of that, I created the Action in this PR to consolidate this logic for Android.

However, then, we had the question of how such public Actions should interact with our "internal" Actions. Internally, we don't do any versioning and just kinda deal with the fallout from that (although, it isn't exactly "free" to introduce versioning...so, pro/con here). With public-facing Actions, we were thinking it might be more prudent to prevent updates to underlying Actions from just taking effect automatically in the public-facing ones. A thought, though, is if Dependabot will bump Git hashes; that is, if the public-facing Actions pin any underlying "internal" Actions with a commit hash, would Dependabot bump them to ensure we test such changes before they are exposed to users.

Anyway, that's where this is right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants