Update default config for sh-imessage #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Feb 13, 2024
bridgeconfig/imessage.tpl.yaml
Outdated
| @@ -153,7 +153,7 @@ bridge: | |||
| # Maximum number of messages to backfill for new portal rooms. | |||
| initial_limit: 100 | |||
| # Maximum age of chats to sync in days. | |||
| initial_sync_max_age: 0.5 | |||
| initial_sync_max_age: 14 | |||
There was a problem hiding this comment.
Not sure if it should be that high by default, might be better to just add a way to override config fields with bbctl run arguments
There was a problem hiding this comment.
Gotcha. It's been super Speedy in my experience with Don's changes, but I can for sure set it to like 7 days with a way to override in params?
tulir
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates default number of days to backfill from 0.5 days to 2 weeks, changes param to fix imessage contact names and photos across all platforms. Tested with bluebubbles and applescript connectors