Apply window insets to accommodate system UI. #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbakker
requested changes
Nov 30, 2024
app/src/main/java/com/beemdevelopment/aegis/util/ViewUtils.java
Outdated
Show resolved
Hide resolved
|
Thanks! Could you squash your work into a single commit? |
cillyvms
force-pushed
the
window-insets
branch
from
e979337 to
6039cfa
Compare
|
Sure, the squash went through. Please check if it's still all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not have UI elements obscured by system bars on Android 15, this PR adds bottom padding to lists in the main vault view, preferences and about.
As for the AppBar,
android:fitsSystemWindows="true"only makes the top insets get applied, so I had to manually apply the left and right ones as well. Google seems to recommend usingViewCompat.setOnApplyWindowInsetsListeneroverandroid:fitsSystemWindowsfor this reason. (Tip 10)Fixes #1549