Add support for new Authenticator Pro backup format #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for Authenticator Pro's latest backup format changes. The format of the content itself has not changed as far as I can tell, but they do use a different cipher and KDF now: AES GCM and Argon2id, respectively. The memory cost is statically set at 64MiB. I suspect that this may cause OOM situations on some lower-end devices, but we'll see, not much we can do about that right now without making more changes.
michaelschattgen
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Authenticator Pro's latest backup format changes. The format of the content itself has not changed as far as I can tell, but they do use a different cipher and KDF now: AES GCM and Argon2id, respectively.
The memory cost is statically set at 64MiB. I suspect that this may cause OOM situations on some lower-end devices, but we'll see, not much we can do about that right now without making more changes.
Fixes #1176.