Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to skip duplicates during import #1171

Conversation

michaelschattgen
Copy link
Member

This pull request adds the ability to automatically skip potential duplicates whenever Aegis detects import entries that share the same issuer and secret with a token that's already in the vault. The goal of this feature is to simplify the import process as requested in #453 and #1150.

Screenshot

Closes #453. Closes #1150.

Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution! One comment.

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@michaelschattgen michaelschattgen force-pushed the feature/import-duplicates branch from f82e83a to b205438 Compare September 6, 2023 10:40
@michaelschattgen
Copy link
Member Author

Edited the text and changed it to a plural string. Also added a missing check which was causing the snackbar to always be visible.

Ready to merge.

@alexbakker alexbakker merged commit b916697 into beemdevelopment:master Sep 6, 2023
4 checks passed
@michaelschattgen michaelschattgen deleted the feature/import-duplicates branch September 6, 2023 10:50
@Andreisbb
Copy link

Hello, there's still not possible to filter duplicates when importing through scanning Google Auth export qr code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Improve import process (dedup) Feature request: remove duplicate entries
3 participants