-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse sync chief complaints of the patient #15
base: develop
Are you sure you want to change the base?
Conversation
src/main/java/com/iemr/hwc/fhir/config/fhirRestfulServer/FhirRestfulServer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iemr/hwc/fhir/provider/condition/ConditionExtProvider.java
Show resolved
Hide resolved
src/main/java/com/iemr/hwc/data/nurse/BeneficiaryChiefComplaint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iemr/hwc/data/nurse/BeneficiaryChiefComplaint.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the imports and auto wiring, I don't see any changes here. Undo this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this logic is related to the condition controller, it's better to write it in the condition service class(already present). That way our code will be better isolated from theirs and easy to follow and we will not be modifying their code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
condition.setBenFlowID(new StringType(beneficiaryFlowStatus.getBenFlowID()+"")); | ||
} | ||
else { | ||
throw new ResourceNotFoundException("No record found for given benVisitID and BenVisitCode"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of throwing exception, log it as no benVisitID and BenvisitCode. Add continue statement to ignore the record. Can we write in the query to get only records with benVistiID and BenvisitCode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I even think that we don't need to generate an exception because the benVisitID and the visitCode will exist all the time. So I removed the generation of an exception @roopesh-beehyv
For testing:
http://{{baseUrl}}:{{port}}/fhir/Condition?providerServiceMapId=10&vanID=3&lastModif=lt2023-08-01
Curl:
curl --location 'http://{{baseUrl}}:{{port}}/fhir/Condition?providerServiceMapId=10&vanID=3&lastModif=lt2023-08-01'
--header 'Accept: application/json'