rspec improve readability

becomingwisest · Feb 19, 2020 · a368e9a · a368e9a
1 parent b2ba927
commit a368e9a
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/spec/types/cpan_spec.rb b/spec/types/cpan_spec.rb
@@ -15,7 +15,7 @@
       end
     end
     it 'rejects other values' do
-      expect { described_type.new(name: 'test', ensure: 'foo') }.to raise_error(Puppet::Error)
+      expect { is_expected.to be_valid_type.with_set_attributes(ensure: 'foo') }.to raise_error(Puppet::ResourceError)
     end
   end
 
@@ -41,9 +41,7 @@
       end
     end
     it 'rejects other values' do
-      # for some reason expect { be_valid_type.with_set_attributes({:force => 'nope'})}.to raise_error doesn't raise
-      # expect {be_valid_type.with_set_attributes({:force => 'nope'})}.to raise_error(Puppet::ResourceError)
-      expect { described_type.new(name: 'test', force: 'nope') }.to raise_error(Puppet::Error)
+      expect { is_expected.to be_valid_type.with_set_attributes(force: 'nope') }.to raise_error(Puppet::ResourceError)
     end
     it 'defaults to false' do
       expect(described_type.new(name: 'test')[:force]).to eq(false)
@@ -67,7 +65,7 @@
     describe 'invalid values' do
       [true, false, 220, '0', '888', 'invalid'].each do |value|
         it "rejects #{value}" do
-          expect { described_type.new(name: 'test', umask: value) }.to raise_error(Puppet::Error)
+          expect { is_expected.to be_valid_type.with_set_attributes(umask: value) }.to raise_error(Puppet::ResourceError)
         end
       end
     end