Skip to content
This repository has been archived by the owner on Mar 9, 2019. It is now read-only.

Better error message #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better error message #7

wants to merge 1 commit into from

Conversation

6twenty
Copy link

@6twenty 6twenty commented Nov 27, 2014

Ensures that the error raised contains the from and to currency codes.

Prior to this change, the error raised would not contain the from & to currency codes, eg:
Exchange::NoRateError: No rates where found for to 1.380024 at Sun Aug 01 00:00:00 +1200 2010

This is because the method only raises an error when from_code and to_code are nil. This is an perfectly fine way to raise the error, but it also means that those nil values are getting used in the error message string. This commit supplies the original from & to codes as well, so they they may be used in the error message.

This is a fairly ugly and direct way to fix this issue, so feel free to take it or leave it -- but please do add the currency codes to the error message one way or another.

Ensures that the error raised contains the `from` and `to` currency codes.
@julianbei
Copy link

+1

@beatrichartz
Copy link
Owner

I will put some work into this in the next days in order to provide a patch. Thanks for raising the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants