Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soothe scrutinizer #308

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Soothe scrutinizer #308

merged 2 commits into from
Oct 22, 2024

Conversation

koriym
Copy link
Member

@koriym koriym commented Oct 22, 2024

Restore the scrutinizer score to 10.00.

This update simplifies the code by removing the PHP version check before calling the isEnum method. Since the project now requires a PHP version that supports enums, the conditional check is unnecessary. This change enhances readability and maintainability of the code.
Extract body preparation logic from main code block into a new `prepareBody` method. This enhances code readability and maintainability by isolating the responsibility and making the `EmbedInterceptor` class easier to extend and test.
@koriym koriym marked this pull request as ready for review October 22, 2024 23:40
@koriym koriym merged commit 75031f0 into 1.x Oct 22, 2024
31 checks passed
@koriym koriym deleted the soothe-scrutinizer branch October 22, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant