Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conn token from read_body result #821

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Conversation

alisinabh
Copy link
Contributor

The conn token returned from Conn.read_body/1 function should not be ignored as it may contain vital state regarding the connection which has been altered by this function.

For example when using bandit ignoring conn will cause the keepalive mechanism to malfunction! (See mtrudel/bandit#260)

From Plug.Conn.read_body docs:

Like all functions in this module, the conn returned by read_body must be passed to the next stage of your pipeline and should not be ignored.

@alisinabh alisinabh requested a review from a team as a code owner November 5, 2023 04:05
@yordis yordis merged commit 18397fa into beam-community:main Nov 5, 2023
16 checks passed
@yordis
Copy link
Member

yordis commented Nov 5, 2023

🚀 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants