Fix bug where underscore/dasherize misses single characters #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't create an issue for this bug, but I can if you'd like it for tracking purposes. I can also fold this into #315, along with a version bump, if that's easier too. |
mattpolzin
approved these changes
Feb 23, 2024
|
I'll merge this, then let's rebase your other branch and incorporate both changes in the same version and release notes per your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
JSONAPI.Utils.String.underscore/1andJSONAPI.Utils.String.dasherize/1, where dashes or underscores would be missed when following a single character.