Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Only include fixes and features #22

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

doomspork
Copy link
Member

@doomspork doomspork commented Jun 25, 2024

@yordis if I'm not mistaken this change to our configuration will see that we don't generate any releases or changelog updates for chores or refactors. I'm still on the fence but I appreciate not wanting to pollute releases with unnecessary version bumps.

@doomspork doomspork requested a review from yordis June 25, 2024 23:31
@beam-community beam-community deleted a comment Jun 25, 2024
@doomspork doomspork requested a review from btkostner June 25, 2024 23:33
{
"type": "refactor",
"section": "Miscellaneous",
"hidden": false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

but we do-do want to generate changelog and release for refactor since it should end up being a patch release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What section would you put them under? Refactors?

Copy link
Member

@yordis yordis Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using "Miscellaneous"

Also, is there any way to add cute icons per section?

So in another word, remove chore but keep refactor under this config

@doomspork doomspork force-pushed the feat-only-feat-and-fix branch from 5f928cc to 184260d Compare June 25, 2024 23:41
@doomspork doomspork marked this pull request as ready for review June 25, 2024 23:42
@doomspork doomspork added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 60d06c1 Jun 25, 2024
2 checks passed
@doomspork doomspork deleted the feat-only-feat-and-fix branch June 25, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants