optimize missing "Host" header response

bddjr · Dec 11, 2024 · 5149f3c · 5149f3c
1 parent 32d7343
commit 5149f3c
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src_conn.go b/src_conn.go
@@ -74,16 +74,14 @@ func (c *conn) Read(b []byte) (int, error) {
 		c.log("hlfhr: Read request error from ", c.Conn.RemoteAddr(), ": ", err)
 		return 0, ErrHttpOnHttpsPort
 	}
-	if r.Host == "" {
-		const err = "missing required Host header"
-		io.WriteString(c.Conn, "HTTP/1.1 400 Bad Request\r\nConnection: close\r\n\r\n"+err)
-		c.log("hlfhr: Read request error from ", c.Conn.RemoteAddr(), ": "+err)
-		return 0, ErrHttpOnHttpsPort
-	}
 
 	// Response
 	w := NewResponse()
-	if c.srv.HttpOnHttpsPortErrorHandler != nil {
+	if r.Host == "" {
+		// missing "Host" header
+		w.WriteHeader(400)
+		w.WriteString("missing required Host header")
+	} else if c.srv.HttpOnHttpsPortErrorHandler != nil {
 		// Handler
 		c.srv.HttpOnHttpsPortErrorHandler.ServeHTTP(w, r)
 	} else {