Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: addresses check #160

Merged
merged 5 commits into from
Jan 6, 2025
Merged

chore: addresses check #160

merged 5 commits into from
Jan 6, 2025

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Jan 6, 2025

PR-Codex overview

This PR focuses on updating the @biconomy/sdk package from version 0.0.22 to 0.0.23, removing the isTesting helper, and replacing certain addresses with their mainnet counterparts. It also includes various updates to tests and constants.

Detailed summary

  • Updated CHANGELOG.md for version 0.0.23.
  • Removed isTesting helper from src/sdk/account/utils/Utils.ts.
  • Changed version in package.json to 0.0.23.
  • Replaced k1ValidatorFactoryAddress with MAINNET_ADDRESS_K1_VALIDATOR_FACTORY_ADDRESS.
  • Replaced k1ValidatorAddress with MAINNET_ADDRESS_K1_VALIDATOR_ADDRESS.
  • Updated test files to use TEST_ADDRESS_K1_VALIDATOR_ADDRESS and TEST_ADDRESS_K1_VALIDATOR_FACTORY_ADDRESS.
  • Modified getGasFeeValues method to check for Biconomy bundler.
  • Adjusted various imports and references across multiple test files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Jan 6, 2025

size-limit report 📦

Path Size
core (esm) 16.32 KB (+0.24% 🔺)
core (cjs) 22.77 KB (-0.22% 🔽)
bundler (tree-shaking) 518 B (-5.31% 🔽)
paymaster (tree-shaking) 543 B (0%)

@joepegler joepegler force-pushed the chore/add_address_check branch 2 times, most recently from d76f8e5 to 0a85bec Compare January 6, 2025 09:41
@joepegler joepegler force-pushed the chore/add_address_check branch from 0a85bec to 0e621b5 Compare January 6, 2025 09:51
@joepegler joepegler force-pushed the chore/add_address_check branch 3 times, most recently from 7fbd088 to b2f107f Compare January 6, 2025 09:53
@joepegler joepegler force-pushed the chore/add_address_check branch from b2f107f to 48c62c3 Compare January 6, 2025 10:22
@joepegler joepegler force-pushed the chore/add_address_check branch from 2276b71 to 0f98465 Compare January 6, 2025 11:09
@joepegler joepegler merged commit 204f7dd into develop Jan 6, 2025
5 checks passed
@joepegler joepegler deleted the chore/add_address_check branch January 6, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant